SteelDynamite/onyx-tasks
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

refactor(sync): use shared atomic_write in SyncState::save

Browse source 
SyncState::save duplicated the temp+rename+cleanup-on-failure pattern that storage::atomic_write already provides. Replace the inline implementation with a call to atomic_write, completing the consolidation begun for AppConfig::save_to_file and OfflineQueue::save.

https://claude.ai/code/session_01Vk2NBZGFP3YVshDj1CwDjt
This commit is contained in:
Claude 2026-04-29 07:11:29 +00:00
parent 80757345ab
commit 6c0d7257df
No known key found for this signature in database
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
crates/onyx-core/src/sync.rs
View file

@ -528,14 +528,7 @@ impl SyncState {
pub fn save(&self, workspace_path: &Path) -> Result<()> { pub fn save(&self, workspace_path: &Path) -> Result<()> {
let state_path = workspace_path.join(".syncstate.json"); let state_path = workspace_path.join(".syncstate.json");
let content = serde_json::to_string_pretty(self)?; let content = serde_json::to_string_pretty(self)?;
// Atomic write: write to temp file then rename to prevent corruption on crash atomic_write(&state_path, content.as_bytes())?;
let temp_path = workspace_path.join(".syncstate.json.tmp");
std::fs::write(&temp_path, &content)?;
if let Err(e) = std::fs::rename(&temp_path, &state_path) {
// Clean up temp file on rename failure to prevent accumulation
let _ = std::fs::remove_file(&temp_path);
return Err(e.into());
}
Ok(()) Ok(())
} }