From 6c0d7257dfafe65849f4e2d295696aecc6bb7144 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 29 Apr 2026 07:11:29 +0000 Subject: [PATCH] refactor(sync): use shared atomic_write in SyncState::save SyncState::save duplicated the temp+rename+cleanup-on-failure pattern that storage::atomic_write already provides. Replace the inline implementation with a call to atomic_write, completing the consolidation begun for AppConfig::save_to_file and OfflineQueue::save. https://claude.ai/code/session_01Vk2NBZGFP3YVshDj1CwDjt --- crates/onyx-core/src/sync.rs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/crates/onyx-core/src/sync.rs b/crates/onyx-core/src/sync.rs index 7d50be7..307337e 100644 --- a/crates/onyx-core/src/sync.rs +++ b/crates/onyx-core/src/sync.rs @@ -528,14 +528,7 @@ impl SyncState { pub fn save(&self, workspace_path: &Path) -> Result<()> { let state_path = workspace_path.join(".syncstate.json"); let content = serde_json::to_string_pretty(self)?; - // Atomic write: write to temp file then rename to prevent corruption on crash - let temp_path = workspace_path.join(".syncstate.json.tmp"); - std::fs::write(&temp_path, &content)?; - if let Err(e) = std::fs::rename(&temp_path, &state_path) { - // Clean up temp file on rename failure to prevent accumulation - let _ = std::fs::remove_file(&temp_path); - return Err(e.into()); - } + atomic_write(&state_path, content.as_bytes())?; Ok(()) }