SteelDynamite/onyx-tasks
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

refactor(sync): use shared atomic_write in queue/state save

Browse source 
OfflineQueue::save and SyncState::save each had their own copy of the
temp-file + rename + cleanup-on-failure dance, even though storage's
pub(crate) atomic_write is already imported in this file. Inline the
shared helper so the crate has one canonical atomic write path.
This commit is contained in:
Claude 2026-04-25 13:31:26 +00:00
parent 56944360e0
commit ebe09d0afe
No known key found for this signature in database
1 changed files with 2 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
crates/onyx-core/src/sync.rs
View file

@ -341,13 +341,7 @@ impl OfflineQueue {
return Ok(());
}
let content = serde_json::to_string_pretty(self)?;
// Atomic write: write to temp then rename
let temp_path = workspace_path.join(".syncqueue.json.tmp");
std::fs::write(&temp_path, &content)?;
if let Err(e) = std::fs::rename(&temp_path, &queue_path) {
let _ = std::fs::remove_file(&temp_path);
return Err(e.into());
}
atomic_write(&queue_path, content.as_bytes())?;
Ok(())
}
@ -534,14 +528,7 @@ impl SyncState {
pub fn save(&self, workspace_path: &Path) -> Result<()> {
let state_path = workspace_path.join(".syncstate.json");
let content = serde_json::to_string_pretty(self)?;
// Atomic write: write to temp file then rename to prevent corruption on crash
let temp_path = workspace_path.join(".syncstate.json.tmp");
std::fs::write(&temp_path, &content)?;
if let Err(e) = std::fs::rename(&temp_path, &state_path) {
// Clean up temp file on rename failure to prevent accumulation
let _ = std::fs::remove_file(&temp_path);
return Err(e.into());
}
atomic_write(&state_path, content.as_bytes())?;
Ok(())
}