SteelDynamite/onyx-tasks
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(repository): saturating_add for in-memory version bump

Browse source 
create_task used a plain += on the in-memory version returned to the
caller while FileSystemStorage uses saturating_add when serialising
the frontmatter. The two would disagree at u64::MAX, and in debug
builds the + operator would panic on overflow. Match the storage
behaviour.
This commit is contained in:
Claude 2026-04-17 16:20:11 +00:00
parent f276233be5
commit c134624839
No known key found for this signature in database
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
crates/onyx-core/src/repository.rs
View file

@ -26,7 +26,10 @@ impl TaskRepository {
// Task operations // Task operations
pub fn create_task(&mut self, list_id: Uuid, mut task: Task) -> Result<Task> { pub fn create_task(&mut self, list_id: Uuid, mut task: Task) -> Result<Task> {
self.storage.write_task(list_id, &task)?; self.storage.write_task(list_id, &task)?;
task.version += 1; // Mirror the saturating increment that FileSystemStorage applies to
// the on-disk frontmatter so the in-memory Task matches what was
// written and doesn't wrap at u64::MAX.
task.version = task.version.saturating_add(1);
Ok(task) Ok(task)
} }