From 970210b647c7a941bbac808d9f73b316a9aee282 Mon Sep 17 00:00:00 2001 From: Claude Date: Fri, 24 Apr 2026 07:36:28 +0000 Subject: [PATCH] refactor(sync): destructure remote in deleted-local branch The `(None, Some(_), Some(b))` arm re-checked the already-matched `remote` via `remote.is_some_and(...)`, which obscures intent and compiles to redundant None-branch code. Bind `Some(r)` in the match and use `r` directly. No behavior change. --- crates/onyx-core/src/sync.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/crates/onyx-core/src/sync.rs b/crates/onyx-core/src/sync.rs index 6eb2b57..58d9945 100644 --- a/crates/onyx-core/src/sync.rs +++ b/crates/onyx-core/src/sync.rs @@ -204,8 +204,9 @@ pub fn compute_sync_actions( } // Remote present, local gone, base known: local was deleted - (None, Some(_), Some(b)) => { - let remote_changed = remote.is_some_and(|r| r.size != b.size || !timestamps_equal(r.last_modified.as_deref(), b.modified_at.as_deref())); + (None, Some(r), Some(b)) => { + let remote_changed = r.size != b.size + || !timestamps_equal(r.last_modified.as_deref(), b.modified_at.as_deref()); if remote_changed { // deleted locally + modified remotely -> download (remote wins) actions.push(SyncAction::Download { path: path.to_string() });