SteelDynamite/onyx-tasks
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

perf(tauri): use HashSet for cascade-delete dedup

Browse source 
Descendant walking in delete_task called Vec::contains in the inner
loop, making the traversal O(n^2) in the number of tasks. Swap the
visited set to HashSet so membership tests are O(1); HashSet::insert
also folds the contains-check and record-new steps into one call.
This commit is contained in:
Claude 2026-04-20 07:34:52 +00:00
parent 70fe7420cd
commit 6abe95692e
No known key found for this signature in database
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
apps/tauri/src-tauri/src/lib.rs
View file

@ -450,12 +450,11 @@ fn delete_task(
// so deleting a parent can't leave grandchildren orphaned with a // so deleting a parent can't leave grandchildren orphaned with a
// parent_id pointing at a deleted task. // parent_id pointing at a deleted task.
let all_tasks = repo.list_tasks(lid).map_err(|e| e.to_string())?; let all_tasks = repo.list_tasks(lid).map_err(|e| e.to_string())?;
let mut to_delete: Vec<Uuid> = Vec::new(); let mut to_delete: std::collections::HashSet<Uuid> = std::collections::HashSet::new();
let mut frontier: Vec<Uuid> = vec![tid]; let mut frontier: Vec<Uuid> = vec![tid];
while let Some(parent) = frontier.pop() { while let Some(parent) = frontier.pop() {
for t in &all_tasks { for t in &all_tasks {
if t.parent_id == Some(parent) && !to_delete.contains(&t.id) { if t.parent_id == Some(parent) && to_delete.insert(t.id) {
to_delete.push(t.id);
frontier.push(t.id); frontier.push(t.id);
} }
} }