SteelDynamite/onyx-tasks
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(storage): atomic task-file writes

Browse source 
write_task used plain fs::write for the .md payload even though every
other write path in this module (metadata files, sync state, offline
queue, config) uses atomic_write. A crash mid-write left a truncated
.md file whose malformed YAML frontmatter then failed list_tasks for
the entire list. Route through atomic_write so a failed write either
leaves the old file intact or produces the full new file.
This commit is contained in:
Claude 2026-04-17 16:18:09 +00:00
parent a0e2bb214b
commit 604a6058b8
No known key found for this signature in database
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
crates/onyx-core/src/storage.rs
View file

@ -381,7 +381,9 @@ impl Storage for FileSystemStorage {
} }
let content = self.write_markdown_with_frontmatter(task)?; let content = self.write_markdown_with_frontmatter(task)?;
fs::write(&task_path, content)?; // Atomic write: a crash mid-write must not leave a truncated .md file
// that then fails YAML parsing on the next list_tasks/read_task.
atomic_write(&task_path, content.as_bytes())?;
// Update list metadata to include this task in task_order if not already present // Update list metadata to include this task in task_order if not already present
let mut list_metadata = self.read_list_metadata(list_id)?; let mut list_metadata = self.read_list_metadata(list_id)?;